Skip to content

Commit

Permalink
f2fs: compress: remove unneed check condition
Browse files Browse the repository at this point in the history
In only call path of __cluster_may_compress(), __f2fs_write_data_pages()
has checked SBI_POR_DOING condition, and also cluster_may_compress()
has checked CP_ERROR_FLAG condition, so remove redundant check condition
in __cluster_may_compress() for cleanup.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
Chao Yu authored and Jaegeuk Kim committed Apr 26, 2021
1 parent 2e22d48 commit 8af85f7
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions fs/f2fs/compress.c
Original file line number Diff line number Diff line change
Expand Up @@ -890,20 +890,14 @@ bool f2fs_cluster_can_merge_page(struct compress_ctx *cc, pgoff_t index)

static bool __cluster_may_compress(struct compress_ctx *cc)
{
struct f2fs_sb_info *sbi = F2FS_I_SB(cc->inode);
loff_t i_size = i_size_read(cc->inode);
unsigned nr_pages = DIV_ROUND_UP(i_size, PAGE_SIZE);
int i;

for (i = 0; i < cc->cluster_size; i++) {
struct page *page = cc->rpages[i];

f2fs_bug_on(sbi, !page);

if (unlikely(f2fs_cp_error(sbi)))
return false;
if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
return false;
f2fs_bug_on(F2FS_I_SB(cc->inode), !page);

/* beyond EOF */
if (page->index >= nr_pages)
Expand Down

0 comments on commit 8af85f7

Please sign in to comment.