Skip to content

Commit

Permalink
[PARISC] futex: Use same lock set as lws calls
Browse files Browse the repository at this point in the history
In debugging the failure of the glibc tst-cond18 test on parisc, I realized
that futexes need to use the same locks the lws calls.  This fixes all the
pthread 'cond' tests.  Sadly, there are still problems with thread cancellation.

[jejb: checkpatch fixes]
Signed-off-by: John David Anglin <dave.anglin@bell.net>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
John David Anglin authored and James Bottomley committed Feb 27, 2012
1 parent 500dd23 commit 8b23281
Showing 1 changed file with 27 additions and 4 deletions.
31 changes: 27 additions & 4 deletions arch/parisc/include/asm/futex.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,29 @@
#include <asm/atomic.h>
#include <asm/errno.h>

/* The following has to match the LWS code in syscall.S. We have
sixteen four-word locks. */

static inline void
_futex_spin_lock_irqsave(u32 __user *uaddr, unsigned long int *flags)
{
extern u32 lws_lock_start[];
long index = ((long)uaddr & 0xf0) >> 2;
arch_spinlock_t *s = (arch_spinlock_t *)&lws_lock_start[index];
local_irq_save(*flags);
arch_spin_lock(s);
}

static inline void
_futex_spin_unlock_irqrestore(u32 __user *uaddr, unsigned long int *flags)
{
extern u32 lws_lock_start[];
long index = ((long)uaddr & 0xf0) >> 2;
arch_spinlock_t *s = (arch_spinlock_t *)&lws_lock_start[index];
arch_spin_unlock(s);
local_irq_restore(*flags);
}

static inline int
futex_atomic_op_inuser (int encoded_op, u32 __user *uaddr)
{
Expand All @@ -26,7 +49,7 @@ futex_atomic_op_inuser (int encoded_op, u32 __user *uaddr)

pagefault_disable();

_atomic_spin_lock_irqsave(uaddr, flags);
_futex_spin_lock_irqsave(uaddr, &flags);

switch (op) {
case FUTEX_OP_SET:
Expand Down Expand Up @@ -71,7 +94,7 @@ futex_atomic_op_inuser (int encoded_op, u32 __user *uaddr)
ret = -ENOSYS;
}

_atomic_spin_unlock_irqrestore(uaddr, flags);
_futex_spin_unlock_irqrestore(uaddr, &flags);

pagefault_enable();

Expand Down Expand Up @@ -113,7 +136,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
* address. This should scale to a couple of CPUs.
*/

_atomic_spin_lock_irqsave(uaddr, flags);
_futex_spin_lock_irqsave(uaddr, &flags);

ret = get_user(val, uaddr);

Expand All @@ -122,7 +145,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,

*uval = val;

_atomic_spin_unlock_irqrestore(uaddr, flags);
_futex_spin_unlock_irqrestore(uaddr, &flags);

return ret;
}
Expand Down

0 comments on commit 8b23281

Please sign in to comment.