Skip to content

Commit

Permalink
firewire: cdev: fix fw_cdev_event_bus_reset emission after local conf…
Browse files Browse the repository at this point in the history
…ig ROM changes

When a descriptor was added or removed to the local node's config ROM,
userspace clients which had a local node's /dev/fw* open did not receive
any fw_cdev_event_bus_reset for poll()/read() consumption.

The cause was that the core-device.c facility which re-reads the config
ROM of the bus reset initiator node missed to call the fw_device update
function.  The fw_units are destroyed and newly added, but their parent
stays and needs to be updated.

Reported-by: Jay Fenlason <fenlason@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Jul 13, 2010
1 parent eb5b35a commit 8b4f70b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/firewire/core-device.c
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,7 @@ static void fw_device_refresh(struct work_struct *work)
goto give_up;
}

fw_device_cdev_update(device);
create_units(device);

/* Userspace may want to re-read attributes. */
Expand Down

0 comments on commit 8b4f70b

Please sign in to comment.