Skip to content

Commit

Permalink
net: dsa: bcm_sf2: Disable learning for ASP port
Browse files Browse the repository at this point in the history
We don't want to enable learning for the ASP port since it only receives
directed traffic, this allows us to bypass ARL-driven forwarding rules
which could conflict with Broadcom tags and/or CFP forwarding.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Florian Fainelli authored and David S. Miller committed Mar 31, 2020
1 parent 31bfc2d commit 8b6b208
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion drivers/net/dsa/bcm_sf2.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,17 @@ static int bcm_sf2_port_setup(struct dsa_switch *ds, int port,
core_writel(priv, reg, CORE_DIS_LEARN);

/* Enable Broadcom tags for that port if requested */
if (priv->brcm_tag_mask & BIT(port))
if (priv->brcm_tag_mask & BIT(port)) {
b53_brcm_hdr_setup(ds, port);

/* Disable learning on ASP port */
if (port == 7) {
reg = core_readl(priv, CORE_DIS_LEARN);
reg |= BIT(port);
core_writel(priv, reg, CORE_DIS_LEARN);
}
}

/* Configure Traffic Class to QoS mapping, allow each priority to map
* to a different queue number
*/
Expand Down

0 comments on commit 8b6b208

Please sign in to comment.