Skip to content

Commit

Permalink
printk: when dumping regs, show the stack, not thread_info
Browse files Browse the repository at this point in the history
We currently show:

  task: <current> ti: <current_thread_info()> task.ti: <task_thread_info(current)>"

"ti" and "task.ti" are redundant, and neither is actually what we want
to show, which the the base of the thread stack.  Change the display to
show the stack pointer explicitly.

Link: http://lkml.kernel.org/r/543ac5bd66ff94000a57a02e11af7239571a3055.1468523549.git.luto@kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andy Lutomirski authored and Linus Torvalds committed Jul 28, 2016
1 parent e558af6 commit 8b70ca6
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions kernel/printk/printk.c
Original file line number Diff line number Diff line change
Expand Up @@ -3177,9 +3177,8 @@ void show_regs_print_info(const char *log_lvl)
{
dump_stack_print_info(log_lvl);

printk("%stask: %p ti: %p task.ti: %p\n",
log_lvl, current, current_thread_info(),
task_thread_info(current));
printk("%stask: %p task.stack: %p\n",
log_lvl, current, task_stack_page(current));
}

#endif

0 comments on commit 8b70ca6

Please sign in to comment.