Skip to content

Commit

Permalink
mmc: core: Only change mode if mmc_select_bus_width() is successful
Browse files Browse the repository at this point in the history
mmc_select_bus_width() returns bus width (4 or 8) on success or
zero if unsupported. So only change mode if setting the bus width
is successful.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Peter Griffin authored and Ulf Hansson committed Jul 25, 2016
1 parent c6d8fd6 commit 8b7be8f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mmc/core/mmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,7 @@ static int mmc_select_hs200(struct mmc_card *card)
* switch to HS200 mode if bus width is set successfully.
*/
err = mmc_select_bus_width(card);
if (err >= 0) {
if (err > 0) {
val = EXT_CSD_TIMING_HS200 |
card->drive_strength << EXT_CSD_DRV_STR_SHIFT;
err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
Expand Down Expand Up @@ -1642,7 +1642,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
} else if (mmc_card_hs(card)) {
/* Select the desired bus width optionally */
err = mmc_select_bus_width(card);
if (err >= 0) {
if (err > 0) {
err = mmc_select_hs_ddr(card);
if (err)
goto free_card;
Expand Down

0 comments on commit 8b7be8f

Please sign in to comment.