Skip to content

Commit

Permalink
rxrpc: Pass the connection pointer to rxrpc_post_packet_to_call()
Browse files Browse the repository at this point in the history
Pass the connection pointer to rxrpc_post_packet_to_call() as the call
might get disconnected whilst we're looking at it, but the connection
pointer determined by rxrpc_data_read() is guaranteed by RCU for the
duration of the call.

Signed-off-by: David Howells <dhowells@redhat.com>
  • Loading branch information
David Howells committed Sep 7, 2016
1 parent 278ac0c commit 8b7fac5
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions net/rxrpc/input.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,8 @@ static void rxrpc_process_jumbo_packet(struct rxrpc_call *call,
* post an incoming packet to the appropriate call/socket to deal with
* - must get rid of the sk_buff, either by freeing it or by queuing it
*/
static void rxrpc_post_packet_to_call(struct rxrpc_call *call,
static void rxrpc_post_packet_to_call(struct rxrpc_connection *conn,
struct rxrpc_call *call,
struct sk_buff *skb)
{
struct rxrpc_skb_priv *sp;
Expand Down Expand Up @@ -558,7 +559,7 @@ static void rxrpc_post_packet_to_call(struct rxrpc_call *call,
dead_call:
if (sp->hdr.type != RXRPC_PACKET_TYPE_ABORT) {
skb->priority = RX_CALL_DEAD;
rxrpc_reject_packet(call->conn->params.local, skb);
rxrpc_reject_packet(conn->params.local, skb);
goto unlock;
}
free_unlock:
Expand Down Expand Up @@ -754,7 +755,7 @@ void rxrpc_data_ready(struct sock *sk)
goto cant_route_call;

rxrpc_see_call(call);
rxrpc_post_packet_to_call(call, skb);
rxrpc_post_packet_to_call(conn, call, skb);
goto out_unlock;
}

Expand Down

0 comments on commit 8b7fac5

Please sign in to comment.