Skip to content

Commit

Permalink
ASoC: rt5640: Add minimal support for RT5642
Browse files Browse the repository at this point in the history
We have been using rt5640.c codec driver with RT5642 codec chip before commit
022d21f ("ASoC: rt5640: add rt5639 support"). That commits starts using
device ID reading in reset register for adding device specific controls and
routes runtime.

Now since device ID appears to be different between RT5640 and RT5642 the
driver doesn't add those controls and routes that are valid also on RT5642.

Fix this by adding a device ID found by debugging and minimal code for
supporting RT5642.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Bard Liao <bardliao@realtek.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Bard Liao authored and Mark Brown committed Apr 22, 2014
1 parent 908b703 commit 8bfc6d2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
8 changes: 5 additions & 3 deletions sound/soc/codecs/rt5640.c
Original file line number Diff line number Diff line change
Expand Up @@ -1997,8 +1997,9 @@ static int rt5640_probe(struct snd_soc_codec *codec)
snd_soc_update_bits(codec, RT5640_MICBIAS, 0x0030, 0x0030);
snd_soc_update_bits(codec, RT5640_DSP_PATH2, 0xfc00, 0x0c00);

switch (snd_soc_read(codec, RT5640_RESET)) {
case RT5640_RESET_ID:
switch (snd_soc_read(codec, RT5640_RESET) & RT5640_ID_MASK) {
case RT5640_ID_5640:
case RT5640_ID_5642:
snd_soc_add_codec_controls(codec,
rt5640_specific_snd_controls,
ARRAY_SIZE(rt5640_specific_snd_controls));
Expand All @@ -2009,7 +2010,7 @@ static int rt5640_probe(struct snd_soc_codec *codec)
rt5640_specific_dapm_routes,
ARRAY_SIZE(rt5640_specific_dapm_routes));
break;
case RT5639_RESET_ID:
case RT5640_ID_5639:
snd_soc_dapm_new_controls(&codec->dapm,
rt5639_specific_dapm_widgets,
ARRAY_SIZE(rt5639_specific_dapm_widgets));
Expand Down Expand Up @@ -2149,6 +2150,7 @@ static const struct regmap_config rt5640_regmap = {
static const struct i2c_device_id rt5640_i2c_id[] = {
{ "rt5640", 0 },
{ "rt5639", 0 },
{ "rt5642", 0 },
{ }
};
MODULE_DEVICE_TABLE(i2c, rt5640_i2c_id);
Expand Down
10 changes: 7 additions & 3 deletions sound/soc/codecs/rt5640.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@

#include <sound/rt5640.h>

#define RT5639_RESET_ID 0x0008
#define RT5640_RESET_ID 0x000c

/* Info */
#define RT5640_RESET 0x00
#define RT5640_VENDOR_ID 0xfd
Expand Down Expand Up @@ -195,6 +192,13 @@
#define RT5640_R_VOL_MASK (0x3f)
#define RT5640_R_VOL_SFT 0

/* SW Reset & Device ID (0x00) */
#define RT5640_ID_MASK (0x3 << 1)
#define RT5640_ID_5639 (0x0 << 1)
#define RT5640_ID_5640 (0x1 << 1)
#define RT5640_ID_5642 (0x3 << 1)


/* IN1 and IN2 Control (0x0d) */
/* IN3 and IN4 Control (0x0e) */
#define RT5640_BST_SFT1 12
Expand Down

0 comments on commit 8bfc6d2

Please sign in to comment.