Skip to content

Commit

Permalink
pwm: ep93xx: Implement .apply callback
Browse files Browse the repository at this point in the history
To ease review this reuses the formerly implemented callbacks.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Uwe Kleine-König authored and Thierry Reding committed Jun 28, 2021
1 parent 180b50b commit 8bfcbf1
Showing 1 changed file with 39 additions and 4 deletions.
43 changes: 39 additions & 4 deletions drivers/pwm/pwm-ep93xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,48 @@ static void ep93xx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
clk_disable(ep93xx_pwm->clk);
}

static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
const struct pwm_state *state)
{
int ret;
bool enabled = state->enabled;

if (state->polarity != pwm->state.polarity) {
if (enabled) {
ep93xx_pwm_disable(chip, pwm);
enabled = false;
}

ret = ep93xx_pwm_polarity(chip, pwm, state->polarity);
if (ret)
return ret;
}

if (!state->enabled) {
if (enabled)
ep93xx_pwm_disable(chip, pwm);

return 0;
}

if (state->period != pwm->state.period ||
state->duty_cycle != pwm->state.duty_cycle) {
ret = ep93xx_pwm_config(chip, pwm, (int)state->duty_cycle,
(int)state->period);
if (ret)
return ret;
}

if (!enabled)
return ep93xx_pwm_enable(chip, pwm);

return 0;
}

static const struct pwm_ops ep93xx_pwm_ops = {
.request = ep93xx_pwm_request,
.free = ep93xx_pwm_free,
.config = ep93xx_pwm_config,
.set_polarity = ep93xx_pwm_polarity,
.enable = ep93xx_pwm_enable,
.disable = ep93xx_pwm_disable,
.apply = ep93xx_pwm_apply,
.owner = THIS_MODULE,
};

Expand Down

0 comments on commit 8bfcbf1

Please sign in to comment.