Skip to content

Commit

Permalink
kprobes: no need to check return value of debugfs_create functions
Browse files Browse the repository at this point in the history
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Jun 3, 2019
1 parent 4aa3b1f commit 8c0fd1f
Showing 1 changed file with 6 additions and 19 deletions.
25 changes: 6 additions & 19 deletions kernel/kprobes.c
Original file line number Diff line number Diff line change
Expand Up @@ -2570,33 +2570,20 @@ static const struct file_operations fops_kp = {

static int __init debugfs_kprobe_init(void)
{
struct dentry *dir, *file;
struct dentry *dir;
unsigned int value = 1;

dir = debugfs_create_dir("kprobes", NULL);
if (!dir)
return -ENOMEM;

file = debugfs_create_file("list", 0400, dir, NULL,
&debugfs_kprobes_operations);
if (!file)
goto error;
debugfs_create_file("list", 0400, dir, NULL,
&debugfs_kprobes_operations);

file = debugfs_create_file("enabled", 0600, dir,
&value, &fops_kp);
if (!file)
goto error;
debugfs_create_file("enabled", 0600, dir, &value, &fops_kp);

file = debugfs_create_file("blacklist", 0400, dir, NULL,
&debugfs_kprobe_blacklist_ops);
if (!file)
goto error;
debugfs_create_file("blacklist", 0400, dir, NULL,
&debugfs_kprobe_blacklist_ops);

return 0;

error:
debugfs_remove(dir);
return -ENOMEM;
}

late_initcall(debugfs_kprobe_init);
Expand Down

0 comments on commit 8c0fd1f

Please sign in to comment.