Skip to content

Commit

Permalink
rtc: use boolean values with device_init_wakeup()
Browse files Browse the repository at this point in the history 
device_init_wakeup() second argument is a bool type. Use proper boolean
values when calling it to match the type and to produce unambiguous code
which is easier to understand.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Link: https://lore.kernel.org/r/20241217071331.3607-2-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  • Loading branch information
Wolfram Sang authored and Alexandre Belloni committed Jan 9, 2025
1 parent 7158c61 commit 8c28c49
Show file tree
Hide file tree
Showing 53 changed files with 62 additions and 62 deletions.
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-88pm80x.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ static int pm80x_rtc_probe(struct platform_device *pdev)
/* remember whether this power up is caused by PMIC RTC or not */
info->rtc_dev->dev.platform_data = &pdata->rtc_wakeup;

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

return 0;
out_rtc:
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-88pm860x.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ static int pm860x_rtc_probe(struct platform_device *pdev)
schedule_delayed_work(&info->calib_work, VRTC_CALIB_INTERVAL);
#endif /* VRTC_CALIBRATION */

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

return 0;
}
Expand Down
6 changes: 3 additions & 3 deletions drivers/rtc/rtc-amlogic-a4.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ static int aml_rtc_probe(struct platform_device *pdev)
"failed to get_enable rtc sys clk\n");
aml_rtc_init(rtc);

device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);
platform_set_drvdata(pdev, rtc);

rtc->rtc_dev = devm_rtc_allocate_device(dev);
Expand Down Expand Up @@ -391,7 +391,7 @@ static int aml_rtc_probe(struct platform_device *pdev)
return 0;
err_clk:
clk_disable_unprepare(rtc->sys_clk);
device_init_wakeup(dev, 0);
device_init_wakeup(dev, false);

return ret;
}
Expand Down Expand Up @@ -426,7 +426,7 @@ static void aml_rtc_remove(struct platform_device *pdev)
struct aml_rtc_data *rtc = dev_get_drvdata(&pdev->dev);

clk_disable_unprepare(rtc->sys_clk);
device_init_wakeup(&pdev->dev, 0);
device_init_wakeup(&pdev->dev, false);
}

static const struct aml_rtc_config a5_rtc_config = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-armada38x.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ static __init int armada38x_rtc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rtc);

if (rtc->irq != -1)
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
else
clear_bit(RTC_FEATURE_ALARM, rtc->rtc_dev->features);

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-as3722.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ static int as3722_rtc_probe(struct platform_device *pdev)
return ret;
}

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

as3722_rtc->rtc = devm_rtc_device_register(&pdev->dev, "as3722-rtc",
&as3722_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-at91rm9200.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
* being wake-capable; if it didn't, do that here.
*/
if (!device_can_wakeup(&pdev->dev))
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

if (at91_rtc_config->has_correction)
rtc->ops = &sama5d4_rtc_ops;
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-at91sam9.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ static int at91_rtc_probe(struct platform_device *pdev)

/* platform setup code should have handled this; sigh */
if (!device_can_wakeup(&pdev->dev))
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

platform_set_drvdata(pdev, rtc);

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-cadence.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ static void cdns_rtc_remove(struct platform_device *pdev)
struct cdns_rtc *crtc = platform_get_drvdata(pdev);

cdns_rtc_alarm_irq_enable(&pdev->dev, 0);
device_init_wakeup(&pdev->dev, 0);
device_init_wakeup(&pdev->dev, false);

clk_disable_unprepare(crtc->pclk);
clk_disable_unprepare(crtc->ref_clk);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-cmos.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ static void acpi_cmos_wake_setup(struct device *dev)
dev_info(dev, "RTC can wake from S4\n");

/* RTC always wakes from S1/S2/S3, and often S4/STD */
device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);
}

static void cmos_check_acpi_rtc_status(struct device *dev,
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-cpcap.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
}
disable_irq(rtc->update_irq);

err = device_init_wakeup(dev, 1);
err = device_init_wakeup(dev, true);
if (err) {
dev_err(dev, "wakeup initialization failed (%d)\n", err);
/* ignore error and continue without wakeup support */
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-cros-ec.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ static int cros_ec_rtc_probe(struct platform_device *pdev)
return ret;
}

ret = device_init_wakeup(&pdev->dev, 1);
ret = device_init_wakeup(&pdev->dev, true);
if (ret) {
dev_err(&pdev->dev, "failed to initialize wakeup\n");
return ret;
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-da9055.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ static int da9055_rtc_probe(struct platform_device *pdev)
if (ret & DA9055_RTC_ALM_EN)
rtc->alarm_enable = 1;

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
&da9055_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-ds3232.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ static int ds3232_probe(struct device *dev, struct regmap *regmap, int irq,
return ret;

if (ds3232->irq > 0)
device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);

ds3232_hwmon_register(dev, name);

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-isl1208.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ static int isl1208_setup_irq(struct i2c_client *client, int irq)
isl1208_driver.driver.name,
client);
if (!rc) {
device_init_wakeup(&client->dev, 1);
device_init_wakeup(&client->dev, true);
enable_irq_wake(irq);
} else {
dev_err(&client->dev,
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-jz4740.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ static int jz4740_rtc_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, rtc);

device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);

ret = dev_pm_set_wake_irq(dev, irq);
if (ret)
Expand Down
4 changes: 2 additions & 2 deletions drivers/rtc/rtc-loongson.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ static int loongson_rtc_probe(struct platform_device *pdev)
alarm_irq);

priv->pm_base = regs - priv->config->pm_offset;
device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);

if (has_acpi_companion(dev))
acpi_install_fixed_event_handler(ACPI_EVENT_RTC,
Expand Down Expand Up @@ -360,7 +360,7 @@ static void loongson_rtc_remove(struct platform_device *pdev)
acpi_remove_fixed_event_handler(ACPI_EVENT_RTC,
loongson_rtc_handler);

device_init_wakeup(dev, 0);
device_init_wakeup(dev, false);
loongson_rtc_alarm_irq_enable(dev, 0);
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-lp8788.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ static int lp8788_rtc_probe(struct platform_device *pdev)
rtc->alarm = lp->pdata ? lp->pdata->alarm_sel : DEFAULT_ALARM_SEL;
platform_set_drvdata(pdev, rtc);

device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);

rtc->rdev = devm_rtc_device_register(dev, "lp8788_rtc",
&lp8788_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-lpc32xx.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ static int lpc32xx_rtc_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "Can't request interrupt.\n");
rtc->irq = -1;
} else {
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
}
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-max77686.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ static int max77686_rtc_probe(struct platform_device *pdev)
goto err_rtc;
}

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

info->rtc_dev = devm_rtc_device_register(&pdev->dev, id->name,
&max77686_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-max8925.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ static int max8925_rtc_probe(struct platform_device *pdev)
/* XXX - isn't this redundant? */
platform_set_drvdata(pdev, info);

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

info->rtc_dev = devm_rtc_device_register(&pdev->dev, "max8925-rtc",
&max8925_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-max8997.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ static int max8997_rtc_probe(struct platform_device *pdev)
max8997_rtc_enable_wtsr(info, true);
max8997_rtc_enable_smpl(info, true);

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

info->rtc_dev = devm_rtc_device_register(&pdev->dev, "max8997-rtc",
&max8997_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-meson-vrtc.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ static int meson_vrtc_probe(struct platform_device *pdev)
if (IS_ERR(vrtc->io_alarm))
return PTR_ERR(vrtc->io_alarm);

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

platform_set_drvdata(pdev, vrtc);

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-mpc5121.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ static int mpc5121_rtc_probe(struct platform_device *op)
return PTR_ERR(rtc->regs);
}

device_init_wakeup(&op->dev, 1);
device_init_wakeup(&op->dev, true);

platform_set_drvdata(op, rtc);

Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-mt6397.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ static int mtk_rtc_probe(struct platform_device *pdev)
return ret;
}

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

rtc->rtc_dev->ops = &mtk_rtc_ops;
rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900;
Expand Down
4 changes: 2 additions & 2 deletions drivers/rtc/rtc-mv.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ static int __init mv_rtc_probe(struct platform_device *pdev)
}

if (pdata->irq >= 0)
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
else
clear_bit(RTC_FEATURE_ALARM, pdata->rtc->features);

Expand All @@ -287,7 +287,7 @@ static void __exit mv_rtc_remove(struct platform_device *pdev)
struct rtc_plat_data *pdata = platform_get_drvdata(pdev);

if (pdata->irq >= 0)
device_init_wakeup(&pdev->dev, 0);
device_init_wakeup(&pdev->dev, false);

if (!IS_ERR(pdata->clk))
clk_disable_unprepare(pdata->clk);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-mxc.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ static int mxc_rtc_probe(struct platform_device *pdev)
}

if (pdata->irq >= 0) {
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
ret = dev_pm_set_wake_irq(&pdev->dev, pdata->irq);
if (ret)
dev_err(&pdev->dev, "failed to enable irq wake\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-mxc_v2.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ static int mxc_rtc_probe(struct platform_device *pdev)
if (pdata->irq < 0)
return pdata->irq;

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
ret = dev_pm_set_wake_irq(&pdev->dev, pdata->irq);
if (ret)
dev_err(&pdev->dev, "failed to enable irq wake\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-omap.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ static void omap_rtc_remove(struct platform_device *pdev)
omap_rtc_power_off_rtc = NULL;
}

device_init_wakeup(&pdev->dev, 0);
device_init_wakeup(&pdev->dev, false);

if (!IS_ERR(rtc->clk))
clk_disable_unprepare(rtc->clk);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-palmas.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ static int palmas_rtc_probe(struct platform_device *pdev)

palmas_rtc->irq = platform_get_irq(pdev, 0);

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
palmas_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
&palmas_rtc_ops, THIS_MODULE);
if (IS_ERR(palmas_rtc->rtc)) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-pic32.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ static int pic32_rtc_probe(struct platform_device *pdev)

pic32_rtc_enable(pdata, 1);

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

pdata->rtc->ops = &pic32_rtcops;
pdata->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-pm8xxx.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, rtc_dd);

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

rtc_dd->rtc = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(rtc_dd->rtc))
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-pxa.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
return ret;
}

device_init_wakeup(dev, 1);
device_init_wakeup(dev, true);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-rc5t583.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ static int rc5t583_rtc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "IRQ is not free.\n");
return ret;
}
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

ricoh_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
&rc5t583_rtc_ops, THIS_MODULE);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-rc5t619.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ static int rc5t619_rtc_probe(struct platform_device *pdev)

} else {
/* enable wake */
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
enable_irq_wake(rtc->irq);
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-renesas-rtca3.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ static int rtca3_probe(struct platform_device *pdev)
if (ret)
return ret;

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

priv->rtc_dev = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(priv->rtc_dev))
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-rk808.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ static int rk808_rtc_probe(struct platform_device *pdev)
return ret;
}

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

rk808_rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(rk808_rtc->rtc))
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-s3c.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
dev_dbg(&pdev->dev, "s3c2410_rtc: RTCCON=%02x\n",
readw(info->base + S3C2410_RTCCON));

device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

info->rtc = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(info->rtc)) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-s5m.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ static int s5m_rtc_probe(struct platform_device *pdev)
info->irq, ret);
return ret;
}
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);
}

return devm_rtc_register_device(info->rtc_dev);
Expand Down
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-sa1100.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ static int sa1100_rtc_probe(struct platform_device *pdev)
}

platform_set_drvdata(pdev, info);
device_init_wakeup(&pdev->dev, 1);
device_init_wakeup(&pdev->dev, true);

return sa1100_rtc_init(pdev, info);
}
Expand Down
Loading

0 comments on commit 8c28c49

Please sign in to comment.