Skip to content

Commit

Permalink
pwm: stm32: Simplify using devm_pwmchip_add()
Browse files Browse the repository at this point in the history
This allows to drop the platform_driver's remove function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Uwe Kleine-König authored and Thierry Reding committed Jul 28, 2023
1 parent e9c2f69 commit 8c89fd8
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions drivers/pwm/pwm-stm32.c
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ static int stm32_pwm_probe(struct platform_device *pdev)
priv->chip.ops = &stm32pwm_ops;
priv->chip.npwm = stm32_pwm_detect_channels(priv);

ret = pwmchip_add(&priv->chip);
ret = devm_pwmchip_add(dev, &priv->chip);
if (ret < 0)
return ret;

Expand All @@ -646,13 +646,6 @@ static int stm32_pwm_probe(struct platform_device *pdev)
return 0;
}

static void stm32_pwm_remove(struct platform_device *pdev)
{
struct stm32_pwm *priv = platform_get_drvdata(pdev);

pwmchip_remove(&priv->chip);
}

static int __maybe_unused stm32_pwm_suspend(struct device *dev)
{
struct stm32_pwm *priv = dev_get_drvdata(dev);
Expand Down Expand Up @@ -697,7 +690,6 @@ MODULE_DEVICE_TABLE(of, stm32_pwm_of_match);

static struct platform_driver stm32_pwm_driver = {
.probe = stm32_pwm_probe,
.remove_new = stm32_pwm_remove,
.driver = {
.name = "stm32-pwm",
.of_match_table = stm32_pwm_of_match,
Expand Down

0 comments on commit 8c89fd8

Please sign in to comment.