Skip to content

Commit

Permalink
pstore: Add priv field to pstore_record for backend specific use
Browse files Browse the repository at this point in the history
The EFI pstore backend will need to store per-record variable name data
when we switch away from the efivars layer. Add a priv field to struct
pstore_record, and document it as holding a backend specific pointer
that is assumed to be a kmalloc()d buffer, and will be kfree()d when the
entire record is freed.

Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
  • Loading branch information
Ard Biesheuvel committed Jun 24, 2022
1 parent f662092 commit 8ca869b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions fs/pstore/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ static void free_pstore_private(struct pstore_private *private)
return;
if (private->record) {
kfree(private->record->buf);
kfree(private->record->priv);
kfree(private->record);
}
kfree(private);
Expand Down
1 change: 1 addition & 0 deletions fs/pstore/platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,7 @@ void pstore_get_backend_records(struct pstore_info *psi,
if (rc) {
/* pstore_mkfile() did not take record, so free it. */
kfree(record->buf);
kfree(record->priv);
kfree(record);
if (rc != -EEXIST || !quiet)
failed++;
Expand Down
4 changes: 4 additions & 0 deletions include/linux/pstore.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ struct pstore_info;
* @size: size of @buf
* @ecc_notice_size:
* ECC information for @buf
* @priv: pointer for backend specific use, will be
* kfree()d by the pstore core if non-NULL
* when the record is freed.
*
* Valid for PSTORE_TYPE_DMESG @type:
*
Expand All @@ -74,6 +77,7 @@ struct pstore_record {
char *buf;
ssize_t size;
ssize_t ecc_notice_size;
void *priv;

int count;
enum kmsg_dump_reason reason;
Expand Down

0 comments on commit 8ca869b

Please sign in to comment.