Skip to content

Commit

Permalink
perfcounters: fix task clock counter
Browse files Browse the repository at this point in the history
Impact: bugfix

Update the task clock counter to the new math.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Dec 14, 2008
1 parent 9b51f66 commit 8cb391e
Showing 1 changed file with 23 additions and 4 deletions.
27 changes: 23 additions & 4 deletions kernel/perf_counter.c
Original file line number Diff line number Diff line change
Expand Up @@ -850,17 +850,36 @@ static const struct hw_perf_counter_ops perf_ops_cpu_clock = {
.hw_perf_counter_read = cpu_clock_perf_counter_read,
};

static void task_clock_perf_counter_enable(struct perf_counter *counter)
static void task_clock_perf_counter_update(struct perf_counter *counter)
{
u64 prev, now;
s64 delta;

prev = atomic64_read(&counter->hw.prev_count);
now = current->se.sum_exec_runtime;

atomic64_set(&counter->hw.prev_count, now);

delta = now - prev;
if (WARN_ON_ONCE(delta < 0))
delta = 0;

atomic64_add(delta, &counter->count);
}

static void task_clock_perf_counter_disable(struct perf_counter *counter)
static void task_clock_perf_counter_read(struct perf_counter *counter)
{
task_clock_perf_counter_update(counter);
}

static void task_clock_perf_counter_read(struct perf_counter *counter)
static void task_clock_perf_counter_enable(struct perf_counter *counter)
{
atomic64_set(&counter->hw.prev_count, current->se.sum_exec_runtime);
}

static void task_clock_perf_counter_disable(struct perf_counter *counter)
{
atomic64_set(&counter->count, current->se.sum_exec_runtime);
task_clock_perf_counter_update(counter);
}

static const struct hw_perf_counter_ops perf_ops_task_clock = {
Expand Down

0 comments on commit 8cb391e

Please sign in to comment.