Skip to content

Commit

Permalink
net: wan: farsync: use new tasklet API
Browse files Browse the repository at this point in the history
This converts the driver to use the new tasklet API introduced in
commit 12cc923 ("tasklet: Introduce new initialization API")

The new API changes the argument passed to callback functions,
but fortunately it is unused so it is straight forward to use
DECLARE_TASKLET rather than DECLARE_TASLKLET_OLD.

Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Link: https://lore.kernel.org/r/20210204173947.92884-1-kernel@esmil.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Emil Renner Berthing authored and Jakub Kicinski committed Feb 6, 2021
1 parent 9c2865e commit 8cc8993
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/net/wan/farsync.c
Original file line number Diff line number Diff line change
Expand Up @@ -566,11 +566,11 @@ MODULE_DEVICE_TABLE(pci, fst_pci_dev_id);

static void do_bottom_half_tx(struct fst_card_info *card);
static void do_bottom_half_rx(struct fst_card_info *card);
static void fst_process_tx_work_q(unsigned long work_q);
static void fst_process_int_work_q(unsigned long work_q);
static void fst_process_tx_work_q(struct tasklet_struct *unused);
static void fst_process_int_work_q(struct tasklet_struct *unused);

static DECLARE_TASKLET_OLD(fst_tx_task, fst_process_tx_work_q);
static DECLARE_TASKLET_OLD(fst_int_task, fst_process_int_work_q);
static DECLARE_TASKLET(fst_tx_task, fst_process_tx_work_q);
static DECLARE_TASKLET(fst_int_task, fst_process_int_work_q);

static struct fst_card_info *fst_card_array[FST_MAX_CARDS];
static spinlock_t fst_work_q_lock;
Expand Down Expand Up @@ -600,7 +600,7 @@ fst_q_work_item(u64 * queue, int card_index)
}

static void
fst_process_tx_work_q(unsigned long /*void **/work_q)
fst_process_tx_work_q(struct tasklet_struct *unused)
{
unsigned long flags;
u64 work_txq;
Expand Down Expand Up @@ -630,7 +630,7 @@ fst_process_tx_work_q(unsigned long /*void **/work_q)
}

static void
fst_process_int_work_q(unsigned long /*void **/work_q)
fst_process_int_work_q(struct tasklet_struct *unused)
{
unsigned long flags;
u64 work_intq;
Expand Down

0 comments on commit 8cc8993

Please sign in to comment.