Skip to content

Commit

Permalink
iio: adc: ti-ads7924 Drop unnecessary function parameters
Browse files Browse the repository at this point in the history
Device pointer is the only variable which is used by the
ads7924_get_channels_config() and which is declared outside this
function. Still, the function gets the iio_device and i2c_client as
parameters. The sole caller of this function (probe) already has the
device pointer which it can directly pass to the function.

Simplify code by passing the device pointer directly as a parameter
instead of digging it from the iio_device's private data.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://patch.msgid.link/2bb4c61122eca2f3a35f6087e7d9815675013f66.1740993491.git.mazziesaccount@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Matti Vaittinen authored and Jonathan Cameron committed Mar 11, 2025
1 parent cc26591 commit 8d53427
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/iio/adc/ti-ads7924.c
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,8 @@ static const struct iio_info ads7924_info = {
.read_raw = ads7924_read_raw,
};

static int ads7924_get_channels_config(struct i2c_client *client,
struct iio_dev *indio_dev)
static int ads7924_get_channels_config(struct device *dev)
{
struct ads7924_data *priv = iio_priv(indio_dev);
struct device *dev = priv->dev;
struct fwnode_handle *node;
int num_channels = 0;

Expand Down Expand Up @@ -380,7 +377,7 @@ static int ads7924_probe(struct i2c_client *client)
indio_dev->num_channels = ARRAY_SIZE(ads7924_channels);
indio_dev->info = &ads7924_info;

ret = ads7924_get_channels_config(client, indio_dev);
ret = ads7924_get_channels_config(dev);
if (ret < 0)
return dev_err_probe(dev, ret,
"failed to get channels configuration\n");
Expand Down

0 comments on commit 8d53427

Please sign in to comment.