Skip to content

Commit

Permalink
xtensa: fix threadptr reload on return to userspace
Browse files Browse the repository at this point in the history
commit 4229fb1 upstream.

Userspace return code may skip restoring THREADPTR register if there are
no registers that need to be zeroed. This leads to spurious failures in
libc NPTL tests.

Always restore THREADPTR on return to userspace.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Max Filippov authored and Greg Kroah-Hartman committed Sep 21, 2015
1 parent deeff0e commit 8db5a69
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arch/xtensa/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -549,12 +549,13 @@ user_exception_exit:
* (if we have restored WSBITS-1 frames).
*/

2:
#if XCHAL_HAVE_THREADPTR
l32i a3, a1, PT_THREADPTR
wur a3, threadptr
#endif

2: j common_exception_exit
j common_exception_exit

/* This is the kernel exception exit.
* We avoided to do a MOVSP when we entered the exception, but we
Expand Down

0 comments on commit 8db5a69

Please sign in to comment.