Skip to content

Commit

Permalink
[BNX2]: Use msleep().
Browse files Browse the repository at this point in the history
bnx2.c (incorrectly) sets current->state directly to
TASK_UNINTERRUPTIBLE, without going through set_task_state(). However
all the code wants to do is an msleep so just make it do that instead...

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Arjan van de Ven authored and David S. Miller committed Aug 28, 2007
1 parent b07d68b commit 8e54588
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/bnx2.c
Original file line number Diff line number Diff line change
Expand Up @@ -3935,10 +3935,8 @@ bnx2_reset_chip(struct bnx2 *bp, u32 reset_code)
REG_WR(bp, BNX2_PCICFG_MISC_CONFIG, val);

if ((CHIP_ID(bp) == CHIP_ID_5706_A0) ||
(CHIP_ID(bp) == CHIP_ID_5706_A1)) {
current->state = TASK_UNINTERRUPTIBLE;
schedule_timeout(HZ / 50);
}
(CHIP_ID(bp) == CHIP_ID_5706_A1))
msleep(20);

/* Reset takes approximate 30 usec */
for (i = 0; i < 10; i++) {
Expand Down

0 comments on commit 8e54588

Please sign in to comment.