Skip to content

Commit

Permalink
perf/x86/intel/uncore: Delete an unnecessary check before pci_dev_put…
Browse files Browse the repository at this point in the history
…() call

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/54D0B59C.2060106@users.sourceforge.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Markus Elfring authored and Ingo Molnar committed Feb 18, 2015
1 parent a667342 commit 8e57c58
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
Original file line number Diff line number Diff line change
Expand Up @@ -1132,8 +1132,7 @@ static int snbep_pci2phy_map_init(int devid)
}
}

if (ubox_dev)
pci_dev_put(ubox_dev);
pci_dev_put(ubox_dev);

return err ? pcibios_err_to_errno(err) : 0;
}
Expand Down

0 comments on commit 8e57c58

Please sign in to comment.