Skip to content

Commit

Permalink
ASoC: mt6358: Validate Wake on Voice 2 writes
Browse files Browse the repository at this point in the history
Currently the Wake on Voice 2 control accepts and stores any value written
but it reports that only 0 and 1 are valid values. Reject any out of range
values written by userspace.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230224-asoc-mt6358-quick-fixes-v1-2-747d9186be4b@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Mark Brown committed Feb 28, 2023
1 parent 3425dda commit 8e847a4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sound/soc/codecs/mt6358.c
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,9 @@ static int mt6358_put_wov(struct snd_kcontrol *kcontrol,
struct mt6358_priv *priv = snd_soc_component_get_drvdata(c);
int enabled = ucontrol->value.integer.value[0];

if (enabled < 0 || enabled > 1)
return -EINVAL;

if (priv->wov_enabled != enabled) {
if (enabled)
mt6358_enable_wov_phase2(priv);
Expand Down

0 comments on commit 8e847a4

Please sign in to comment.