Skip to content

Commit

Permalink
net: phy: remove unused functions phy_package_[read|write]_mmd
Browse files Browse the repository at this point in the history
These functions have never had a user, so remove them.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/5792e2cd-6f0a-4f7d-a5ef-b932f94d82f3@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  • Loading branch information
Heiner Kallweit authored and Paolo Abeni committed Mar 17, 2025
1 parent 43e2aa5 commit 8ea221b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 83 deletions.
75 changes: 0 additions & 75 deletions drivers/net/phy/phy-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,43 +734,6 @@ int __phy_package_read_mmd(struct phy_device *phydev,
}
EXPORT_SYMBOL(__phy_package_read_mmd);

/**
* phy_package_read_mmd - read MMD reg relative to PHY package base addr
* @phydev: The phy_device struct
* @addr_offset: The offset to be added to PHY package base_addr
* @devad: The MMD to read from
* @regnum: The register on the MMD to read
*
* Convenience helper for reading a register of an MMD on a given PHY
* using the PHY package base address. The base address is added to
* the addr_offset value.
*
* Same calling rules as for phy_read();
*
* NOTE: It's assumed that the entire PHY package is either C22 or C45.
*/
int phy_package_read_mmd(struct phy_device *phydev,
unsigned int addr_offset, int devad,
u32 regnum)
{
int addr = phy_package_address(phydev, addr_offset);
int val;

if (addr < 0)
return addr;

if (regnum > (u16)~0 || devad > 32)
return -EINVAL;

phy_lock_mdio_bus(phydev);
val = mmd_phy_read(phydev->mdio.bus, addr, phydev->is_c45, devad,
regnum);
phy_unlock_mdio_bus(phydev);

return val;
}
EXPORT_SYMBOL(phy_package_read_mmd);

/**
* __phy_package_write_mmd - write MMD reg relative to PHY package base addr
* @phydev: The phy_device struct
Expand Down Expand Up @@ -804,44 +767,6 @@ int __phy_package_write_mmd(struct phy_device *phydev,
}
EXPORT_SYMBOL(__phy_package_write_mmd);

/**
* phy_package_write_mmd - write MMD reg relative to PHY package base addr
* @phydev: The phy_device struct
* @addr_offset: The offset to be added to PHY package base_addr
* @devad: The MMD to write to
* @regnum: The register on the MMD to write
* @val: value to write to @regnum
*
* Convenience helper for writing a register of an MMD on a given PHY
* using the PHY package base address. The base address is added to
* the addr_offset value.
*
* Same calling rules as for phy_write();
*
* NOTE: It's assumed that the entire PHY package is either C22 or C45.
*/
int phy_package_write_mmd(struct phy_device *phydev,
unsigned int addr_offset, int devad,
u32 regnum, u16 val)
{
int addr = phy_package_address(phydev, addr_offset);
int ret;

if (addr < 0)
return addr;

if (regnum > (u16)~0 || devad > 32)
return -EINVAL;

phy_lock_mdio_bus(phydev);
ret = mmd_phy_write(phydev->mdio.bus, addr, phydev->is_c45, devad,
regnum, val);
phy_unlock_mdio_bus(phydev);

return ret;
}
EXPORT_SYMBOL(phy_package_write_mmd);

/**
* phy_modify_changed - Function for modifying a PHY register
* @phydev: the phy_device struct
Expand Down
8 changes: 0 additions & 8 deletions include/linux/phy.h
Original file line number Diff line number Diff line change
Expand Up @@ -2107,14 +2107,6 @@ int __phy_hwtstamp_set(struct phy_device *phydev,
struct kernel_hwtstamp_config *config,
struct netlink_ext_ack *extack);

int phy_package_read_mmd(struct phy_device *phydev,
unsigned int addr_offset, int devad,
u32 regnum);

int phy_package_write_mmd(struct phy_device *phydev,
unsigned int addr_offset, int devad,
u32 regnum, u16 val);

extern const struct bus_type mdio_bus_type;

struct mdio_board_info {
Expand Down

0 comments on commit 8ea221b

Please sign in to comment.