Skip to content

Commit

Permalink
Merge git://git.kvack.org/~bcrl/aio-fixes
Browse files Browse the repository at this point in the history
Pull another aio fix from Ben LaHaise:
 "put_reqs_available() can now be called from within irq context, which
  means that it (and its sibling function get_reqs_available()) now need
  to be irq-safe, not just preempt-safe"

* git://git.kvack.org/~bcrl/aio-fixes:
  aio: protect reqs_available updates from changes in interrupt handlers
  • Loading branch information
Linus Torvalds committed Jul 15, 2014
2 parents 3cf521f + 263782c commit 8ec8ba8
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions fs/aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -830,27 +830,33 @@ void exit_aio(struct mm_struct *mm)
static void put_reqs_available(struct kioctx *ctx, unsigned nr)
{
struct kioctx_cpu *kcpu;
unsigned long flags;

preempt_disable();
kcpu = this_cpu_ptr(ctx->cpu);

local_irq_save(flags);
kcpu->reqs_available += nr;

while (kcpu->reqs_available >= ctx->req_batch * 2) {
kcpu->reqs_available -= ctx->req_batch;
atomic_add(ctx->req_batch, &ctx->reqs_available);
}

local_irq_restore(flags);
preempt_enable();
}

static bool get_reqs_available(struct kioctx *ctx)
{
struct kioctx_cpu *kcpu;
bool ret = false;
unsigned long flags;

preempt_disable();
kcpu = this_cpu_ptr(ctx->cpu);

local_irq_save(flags);
if (!kcpu->reqs_available) {
int old, avail = atomic_read(&ctx->reqs_available);

Expand All @@ -869,6 +875,7 @@ static bool get_reqs_available(struct kioctx *ctx)
ret = true;
kcpu->reqs_available--;
out:
local_irq_restore(flags);
preempt_enable();
return ret;
}
Expand Down

0 comments on commit 8ec8ba8

Please sign in to comment.