Skip to content

Commit

Permalink
rt2x00: Only strip preamble bit in rt2400pci
Browse files Browse the repository at this point in the history
Only rt2400pci can have the preamble bit set in the PLCP value,
for all other drivers it should not be cleared since that will
conflict with the plcp values for OFDM rates.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Ivo van Doorn authored and John W. Linville committed Mar 13, 2008
1 parent f0e62e4 commit 8ed0985
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
5 changes: 3 additions & 2 deletions drivers/net/wireless/rt2x00/rt2400pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1072,9 +1072,10 @@ static void rt2400pci_fill_rxdone(struct queue_entry *entry,

/*
* Obtain the status about this packet.
* The signal is the PLCP value.
* The signal is the PLCP value, and needs to be stripped
* of the preamble bit (0x08).
*/
rxdesc->signal = rt2x00_get_field32(word2, RXD_W2_SIGNAL);
rxdesc->signal = rt2x00_get_field32(word2, RXD_W2_SIGNAL) & ~0x08;
rxdesc->signal_plcp = 1;
rxdesc->rssi = rt2x00_get_field32(word2, RXD_W3_RSSI) -
entry->queue->rt2x00dev->rssi_offset;
Expand Down
7 changes: 0 additions & 7 deletions drivers/net/wireless/rt2x00/rt2x00dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -573,13 +573,6 @@ void rt2x00lib_rxdone(struct queue_entry *entry,
int idx = -1;
u16 fc;

/*
* If the signal is the plcp value,
* we need to strip the preamble bit (0x08).
*/
if (rxdesc->signal_plcp)
rxdesc->signal &= ~0x08;

/*
* Update RX statistics.
*/
Expand Down

0 comments on commit 8ed0985

Please sign in to comment.