Skip to content

Commit

Permalink
Btrfs: free space cache: make sure there is always room for generatio…
Browse files Browse the repository at this point in the history
…n number

io_ctl_set_generation() assumes that the generation number shares
the same page with inline CRCs. Let's make sure this is always true.

Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
  • Loading branch information
Zhihui Zhang authored and David Sterba committed Aug 6, 2018
1 parent 694c51f commit 8f6c72a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/btrfs/free-space-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,9 @@ static int io_ctl_init(struct btrfs_io_ctl *io_ctl, struct inode *inode,
if (btrfs_ino(BTRFS_I(inode)) != BTRFS_FREE_INO_OBJECTID)
check_crcs = 1;

/* Make sure we can fit our crcs into the first page */
/* Make sure we can fit our crcs and generation into the first page */
if (write && check_crcs &&
(num_pages * sizeof(u32)) >= PAGE_SIZE)
(num_pages * sizeof(u32) + sizeof(u64)) > PAGE_SIZE)
return -ENOSPC;

memset(io_ctl, 0, sizeof(struct btrfs_io_ctl));
Expand Down

0 comments on commit 8f6c72a

Please sign in to comment.