Skip to content

Commit

Permalink
dmaengine: s3c24xx-dma: make phy->irq signed for error handling
Browse files Browse the repository at this point in the history
There is a bug in s3c24xx_dma_probe() where we do:

		phy->irq = platform_get_irq(pdev, i);
		if (phy->irq < 0) {

The problem is that "phy->irq" is unsigned so the error handling doesn't
work.  I have changed it to signed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
  • Loading branch information
Dan Carpenter authored and Vinod Koul committed Mar 11, 2014
1 parent 4de9b3b commit 8f83f50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dma/s3c24xx-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ struct s3c24xx_dma_phy {
unsigned int id;
bool valid;
void __iomem *base;
unsigned int irq;
int irq;
struct clk *clk;
spinlock_t lock;
struct s3c24xx_dma_chan *serving;
Expand Down

0 comments on commit 8f83f50

Please sign in to comment.