Skip to content

Commit

Permalink
tty/serial: mark __init early_smh_setup() static
Browse files Browse the repository at this point in the history
We get 1 warning when building kernel with W=1:
drivers/tty/serial/earlycon-arm-semihost.c:56:12: warning: no previous prototype for 'early_smh_setup' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Baoyou Xie authored and Greg Kroah-Hartman committed Sep 2, 2016
1 parent e06b6b8 commit 8f975fe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/tty/serial/earlycon-arm-semihost.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ static void smh_write(struct console *con, const char *s, unsigned n)
uart_console_write(&dev->port, s, n, smh_putc);
}

int __init early_smh_setup(struct earlycon_device *device, const char *opt)
static int
__init early_smh_setup(struct earlycon_device *device, const char *opt)
{
device->con->write = smh_write;
return 0;
Expand Down

0 comments on commit 8f975fe

Please sign in to comment.