Skip to content

Commit

Permalink
gpio: gpio-it87: Add support for IT8620 and IT8628
Browse files Browse the repository at this point in the history
These chips seem to have a 9th GPIO block (thus supporting 72 GPIOs)
which is configured through SuperIO register 0xd2 (output enable) and
0xd3 (simple I/O). This is also the reason why io_size is larger than
on IT8728 / IT8732. Unfortunately I don't have hardware to test this 9th
GPIO block.

I am also not sure about not configuring the Simple I/O registers as the
hardware I have only uses GPIO block 8. Reading back the values of
0xc0-0xc7 (as configured by the BIOS/EFI on my board) shows that all
have 0xff set.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Martin Blumenstingl authored and Linus Walleij committed Mar 31, 2016
1 parent 691998f commit 8fccdb5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ config GPIO_IT87
Say yes here to support GPIO functionality of IT87xx Super I/O chips.

This driver is tested with ITE IT8728 and IT8732 Super I/O chips, and
supports the IT8761E Super I/O chip as well.
supports the IT8761E, IT8620E and IT8628E Super I/O chip as well.

To compile this driver as a module, choose M here: the module will
be called gpio_it87
Expand Down
10 changes: 10 additions & 0 deletions drivers/gpio/gpio-it87.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@

/* Chip Id numbers */
#define NO_DEV_ID 0xffff
#define IT8620_ID 0x8620
#define IT8628_ID 0x8628
#define IT8728_ID 0x8728
#define IT8732_ID 0x8732
#define IT8761_ID 0x8761
Expand Down Expand Up @@ -302,6 +304,14 @@ static int __init it87_gpio_init(void)
it87_gpio->chip = it87_template_chip;

switch (chip_type) {
case IT8620_ID:
case IT8628_ID:
gpio_ba_reg = 0x62;
it87_gpio->io_size = 11;
it87_gpio->output_base = 0xc8;
it87_gpio->simple_size = 0;
it87_gpio->chip.ngpio = 64;
break;
case IT8728_ID:
case IT8732_ID:
gpio_ba_reg = 0x62;
Expand Down

0 comments on commit 8fccdb5

Please sign in to comment.