Skip to content

Commit

Permalink
net/mlx5e: CT: remove useless conversion to PTR_ERR then ERR_PTR
Browse files Browse the repository at this point in the history
Just return the ptr directly.

Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
  • Loading branch information
Saeed Mahameed committed Feb 2, 2021
1 parent 8271e34 commit 902c024
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,6 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
struct mlx5_ct_counter *shared_counter;
struct mlx5_ct_entry *rev_entry;
__be16 tmp_port;
int ret;

/* get the reversed tuple */
tmp_port = rev_tuple.port.src;
Expand Down Expand Up @@ -804,10 +803,8 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
mutex_unlock(&ct_priv->shared_counter_lock);

shared_counter = mlx5_tc_ct_counter_create(ct_priv);
if (IS_ERR(shared_counter)) {
ret = PTR_ERR(shared_counter);
return ERR_PTR(ret);
}
if (IS_ERR(shared_counter))
return shared_counter;

shared_counter->is_shared = true;
refcount_set(&shared_counter->refcount, 1);
Expand Down

0 comments on commit 902c024

Please sign in to comment.