Skip to content

Commit

Permalink
drm/amd/display: check for dp rev before reading lttpr regs
Browse files Browse the repository at this point in the history
[Why]
LTTPR was introduced after DP1.2. Reading LTTPR registers 0xFXXXX
on some DP 1.2 display is causing an unexpected behavior.

[How]
Make sure that we don't read any lttpr registers on 1.2 displays.

Signed-off-by: abdoulaye berthe <abdoulaye.berthe@amd.com>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
abdoulaye berthe authored and Alex Deucher committed Nov 13, 2019
1 parent 8e5100a commit 903e859
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2759,9 +2759,10 @@ static bool retrieve_link_cap(struct dc_link *link)
/* Set default timeout to 3.2ms and read LTTPR capabilities */
bool ext_timeout_support = link->dc->caps.extended_aux_timeout_support &&
!link->dc->config.disable_extended_timeout_support;
link->is_lttpr_mode_transparent = true;

if (ext_timeout_support) {
status = dc_link_aux_configure_timeout(link->ddc, LINK_AUX_DEFAULT_EXTENDED_TIMEOUT_PERIOD);
link->is_lttpr_mode_transparent = true;
}

memset(dpcd_data, '\0', sizeof(dpcd_data));
Expand Down Expand Up @@ -2796,7 +2797,7 @@ static bool retrieve_link_cap(struct dc_link *link)
return false;
}

if (ext_timeout_support) {
if (ext_timeout_support && link->dpcd_caps.dpcd_rev.raw >= 0x14) {
status = core_link_read_dpcd(
link,
DP_PHY_REPEATER_CNT,
Expand Down

0 comments on commit 903e859

Please sign in to comment.