Skip to content

Commit

Permalink
lmLogOpen() broken failure exit
Browse files Browse the repository at this point in the history
Callers of lmLogOpen() expect it to return -E... on failure exits, which
is what it returns, except for the case of blkdev_get_by_dev() failure.
It that case lmLogOpen() return the error with the wrong sign...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
  • Loading branch information
Al Viro committed Jun 7, 2011
1 parent 3ece48a commit 9054760
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/jfs/jfs_logmgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,7 @@ int lmLogOpen(struct super_block *sb)
bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
log);
if (IS_ERR(bdev)) {
rc = -PTR_ERR(bdev);
rc = PTR_ERR(bdev);
goto free;
}

Expand Down

0 comments on commit 9054760

Please sign in to comment.