Skip to content

Commit

Permalink
NFSv4.1: Cleanup
Browse files Browse the repository at this point in the history
It is now completely safe to call nfs41_sequence_free_slot with a NULL
slot.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
  • Loading branch information
Trond Myklebust committed Jan 29, 2014
1 parent a13ce7c commit 905e7da
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions fs/nfs/nfs4filelayout.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,7 @@ static void filelayout_read_call_done(struct rpc_task *task, void *data)

if (test_bit(NFS_IOHDR_REDO, &rdata->header->flags) &&
task->tk_status == 0) {
if (rdata->res.seq_res.sr_slot != NULL)
nfs41_sequence_done(task, &rdata->res.seq_res);
nfs41_sequence_done(task, &rdata->res.seq_res);
return;
}

Expand Down Expand Up @@ -446,8 +445,7 @@ static void filelayout_write_call_done(struct rpc_task *task, void *data)

if (test_bit(NFS_IOHDR_REDO, &wdata->header->flags) &&
task->tk_status == 0) {
if (wdata->res.seq_res.sr_slot != NULL)
nfs41_sequence_done(task, &wdata->res.seq_res);
nfs41_sequence_done(task, &wdata->res.seq_res);
return;
}

Expand Down

0 comments on commit 905e7da

Please sign in to comment.