Skip to content

Commit

Permalink
Input: altera_ps2 - fix test of unsigned in altera_ps2_probe()
Browse files Browse the repository at this point in the history
ps2if->irq is unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Roel Kluin authored and Dmitry Torokhov committed Dec 15, 2009
1 parent d201fd5 commit 909275b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/input/serio/altera_ps2.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ static int __devinit altera_ps2_probe(struct platform_device *pdev)
{
struct ps2if *ps2if;
struct serio *serio;
int error;
int error, irq;

ps2if = kzalloc(sizeof(struct ps2if), GFP_KERNEL);
serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
Expand All @@ -108,11 +108,13 @@ static int __devinit altera_ps2_probe(struct platform_device *pdev)
goto err_free_mem;
}

ps2if->irq = platform_get_irq(pdev, 0);
if (ps2if->irq < 0) {

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
error = -ENXIO;
goto err_free_mem;
}
ps2if->irq = irq;

if (!request_mem_region(ps2if->iomem_res->start,
resource_size(ps2if->iomem_res), pdev->name)) {
Expand Down

0 comments on commit 909275b

Please sign in to comment.