Skip to content

Commit

Permalink
rtw88: remove unused member of struct rtw_hal
Browse files Browse the repository at this point in the history
Remove unused fab_version member from struct rtw_hal.
Some of the checks being made were nonsense.

Signed-off-by: Kevin Lo <kevlo@kevlo.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  • Loading branch information
Kevin Lo authored and Kalle Valo committed Mar 12, 2020
1 parent 2d83ddd commit 90a3932
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions drivers/net/wireless/realtek/rtw88/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,6 @@ static int rtw_chip_parameter_setup(struct rtw_dev *rtwdev)
}

hal->chip_version = rtw_read32(rtwdev, REG_SYS_CFG1);
hal->fab_version = BIT_GET_VENDOR_ID(hal->chip_version) >> 2;
hal->cut_version = BIT_GET_CHIP_VER(hal->chip_version);
hal->mp_chip = (hal->chip_version & BIT_RTL_ID) ? 0 : 1;
if (hal->chip_version & BIT_RF_TYPE_ID) {
Expand All @@ -1133,11 +1132,6 @@ static int rtw_chip_parameter_setup(struct rtw_dev *rtwdev)
hal->antenna_rx = BB_PATH_A;
}

if (hal->fab_version == 2)
hal->fab_version = 1;
else if (hal->fab_version == 1)
hal->fab_version = 2;

efuse->physical_size = chip->phy_efuse_size;
efuse->logical_size = chip->log_efuse_size;
efuse->protect_size = chip->ptct_efuse_size;
Expand Down
1 change: 0 additions & 1 deletion drivers/net/wireless/realtek/rtw88/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -1527,7 +1527,6 @@ struct rtw_hal {
u32 rcr;

u32 chip_version;
u8 fab_version;
u8 cut_version;
u8 mp_chip;
u8 oem_id;
Expand Down

0 comments on commit 90a3932

Please sign in to comment.