Skip to content

Commit

Permalink
drivers/md/md.c: use strreplace()
Browse files Browse the repository at this point in the history
There's no point in starting over when we meet a '/'.  This also
eliminates a stack variable and a little .text.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Rasmus Villemoes authored and Linus Torvalds committed Jun 26, 2015
1 parent a29fd61 commit 90a9bef
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/md/md.c
Original file line number Diff line number Diff line change
Expand Up @@ -2024,7 +2024,6 @@ static int bind_rdev_to_array(struct md_rdev *rdev, struct mddev *mddev)
{
char b[BDEVNAME_SIZE];
struct kobject *ko;
char *s;
int err;

/* prevent duplicates */
Expand Down Expand Up @@ -2070,8 +2069,7 @@ static int bind_rdev_to_array(struct md_rdev *rdev, struct mddev *mddev)
return -EBUSY;
}
bdevname(rdev->bdev,b);
while ( (s=strchr(b, '/')) != NULL)
*s = '!';
strreplace(b, '/', '!');

rdev->mddev = mddev;
printk(KERN_INFO "md: bind<%s>\n", b);
Expand Down

0 comments on commit 90a9bef

Please sign in to comment.