Skip to content

Commit

Permalink
drm/panel: s6e63m0: Make s6e63m0_remove() return void
Browse files Browse the repository at this point in the history
Up to now s6e63m0_remove() returns zero unconditionally. Make it return
void instead which makes it easier to see in the callers that there is
no error to handle.

Also the return value of spi remove callbacks is ignored anyway.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211011132754.2479853-2-u.kleine-koenig@pengutronix.de
  • Loading branch information
Uwe Kleine-König authored and Sam Ravnborg committed Oct 11, 2021
1 parent 5e51cc0 commit 90c45fc
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ static int s6e63m0_dsi_probe(struct mipi_dsi_device *dsi)
static int s6e63m0_dsi_remove(struct mipi_dsi_device *dsi)
{
mipi_dsi_detach(dsi);
return s6e63m0_remove(&dsi->dev);
s6e63m0_remove(&dsi->dev);
return 0;
}

static const struct of_device_id s6e63m0_dsi_of_match[] = {
Expand Down
3 changes: 2 additions & 1 deletion drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ static int s6e63m0_spi_probe(struct spi_device *spi)

static int s6e63m0_spi_remove(struct spi_device *spi)
{
return s6e63m0_remove(&spi->dev);
s6e63m0_remove(&spi->dev);
return 0;
}

static const struct of_device_id s6e63m0_spi_of_match[] = {
Expand Down
4 changes: 1 addition & 3 deletions drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
Original file line number Diff line number Diff line change
Expand Up @@ -749,13 +749,11 @@ int s6e63m0_probe(struct device *dev, void *trsp,
}
EXPORT_SYMBOL_GPL(s6e63m0_probe);

int s6e63m0_remove(struct device *dev)
void s6e63m0_remove(struct device *dev)
{
struct s6e63m0 *ctx = dev_get_drvdata(dev);

drm_panel_remove(&ctx->panel);

return 0;
}
EXPORT_SYMBOL_GPL(s6e63m0_remove);

Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/panel/panel-samsung-s6e63m0.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ int s6e63m0_probe(struct device *dev, void *trsp,
const u8 *data,
size_t len),
bool dsi_mode);
int s6e63m0_remove(struct device *dev);
void s6e63m0_remove(struct device *dev);

#endif /* _PANEL_SAMSUNG_S6E63M0_H */

0 comments on commit 90c45fc

Please sign in to comment.