Skip to content

Commit

Permalink
perf test: Use cycles event in perf record test for leader_sampling
Browse files Browse the repository at this point in the history
On s390 the event instructions can not be used for recording.
This event is only supported by perf stat.

Change the event from instructions to cycles in subtest
test_leader_sampling.

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Suggested-by: James Clark <james.clark@linaro.org>
Reviewed-by: James Clark <james.clark@linaro.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20250131102756.4185235-3-tmricht@linux.ibm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
  • Loading branch information
Thomas Richter authored and Namhyung Kim committed Feb 4, 2025
1 parent 8591994 commit 90d9767
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tools/perf/tests/shell/record.sh
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ test_cgroup() {

test_leader_sampling() {
echo "Basic leader sampling test"
if ! perf record -o "${perfdata}" -e "{instructions,instructions}:Su" -- \
if ! perf record -o "${perfdata}" -e "{cycles,cycles}:Su" -- \
perf test -w brstack 2> /dev/null
then
echo "Leader sampling [Failed record]"
Expand All @@ -243,15 +243,15 @@ test_leader_sampling() {
while IFS= read -r line
do
# Check if the two instruction counts are equal in each record
instructions=$(echo $line | awk '{for(i=1;i<=NF;i++) if($i=="instructions:") print $(i-1)}')
if [ $(($index%2)) -ne 0 ] && [ ${instructions}x != ${prev_instructions}x ]
cycles=$(echo $line | awk '{for(i=1;i<=NF;i++) if($i=="cycles:") print $(i-1)}')
if [ $(($index%2)) -ne 0 ] && [ ${cycles}x != ${prev_cycles}x ]
then
echo "Leader sampling [Failed inconsistent instructions count]"
echo "Leader sampling [Failed inconsistent cycles count]"
err=1
return
fi
index=$(($index+1))
prev_instructions=$instructions
prev_cycles=$cycles
done < $script_output
echo "Basic leader sampling test [Success]"
}
Expand Down

0 comments on commit 90d9767

Please sign in to comment.