Skip to content

Commit

Permalink
sctp: implement enqueue_event for sctp_stream_interleave
Browse files Browse the repository at this point in the history
enqueue_event is added as a member of sctp_stream_interleave, used to
enqueue either data, idata or notification events into user socket rx
queue.

It replaces sctp_ulpq_tail_event used in the other places with
enqueue_event.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Xin Long authored and David S. Miller committed Dec 11, 2017
1 parent bd4d627 commit 9162e0e
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 7 deletions.
2 changes: 2 additions & 0 deletions include/net/sctp/stream_interleave.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ struct sctp_stream_interleave {
bool (*validate_data)(struct sctp_chunk *chunk);
int (*ulpevent_data)(struct sctp_ulpq *ulpq,
struct sctp_chunk *chunk, gfp_t gfp);
int (*enqueue_event)(struct sctp_ulpq *ulpq,
struct sctp_ulpevent *event);
};

void sctp_stream_interleave_init(struct sctp_stream *stream);
Expand Down
2 changes: 1 addition & 1 deletion net/sctp/associola.c
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
event = sctp_ulpevent_make_peer_addr_change(asoc, &addr,
0, spc_state, error, GFP_ATOMIC);
if (event)
sctp_ulpq_tail_event(&asoc->ulpq, event);
asoc->stream.si->enqueue_event(&asoc->ulpq, event);
}

/* Select new active and retran paths. */
Expand Down
2 changes: 1 addition & 1 deletion net/sctp/chunk.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static void sctp_datamsg_destroy(struct sctp_datamsg *msg)
ev = sctp_ulpevent_make_send_failed(asoc, chunk, sent,
error, GFP_ATOMIC);
if (ev)
sctp_ulpq_tail_event(&asoc->ulpq, ev);
asoc->stream.si->enqueue_event(&asoc->ulpq, ev);
}

sctp_chunk_put(chunk);
Expand Down
9 changes: 5 additions & 4 deletions net/sctp/sm_sideeffect.c
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ static void sctp_cmd_process_operr(struct sctp_cmd_seq *cmds,
if (!ev)
return;

sctp_ulpq_tail_event(&asoc->ulpq, ev);
asoc->stream.si->enqueue_event(&asoc->ulpq, ev);

switch (err_hdr->cause) {
case SCTP_ERROR_UNKNOWN_CHUNK:
Expand Down Expand Up @@ -1058,7 +1058,7 @@ static void sctp_cmd_assoc_change(struct sctp_cmd_seq *commands,
asoc->c.sinit_max_instreams,
NULL, GFP_ATOMIC);
if (ev)
sctp_ulpq_tail_event(&asoc->ulpq, ev);
asoc->stream.si->enqueue_event(&asoc->ulpq, ev);
}

/* Helper function to generate an adaptation indication event */
Expand All @@ -1070,7 +1070,7 @@ static void sctp_cmd_adaptation_ind(struct sctp_cmd_seq *commands,
ev = sctp_ulpevent_make_adaptation_indication(asoc, GFP_ATOMIC);

if (ev)
sctp_ulpq_tail_event(&asoc->ulpq, ev);
asoc->stream.si->enqueue_event(&asoc->ulpq, ev);
}


Expand Down Expand Up @@ -1493,7 +1493,8 @@ static int sctp_cmd_interpreter(enum sctp_event event_type,
pr_debug("%s: sm_sideff: event_up:%p, ulpq:%p\n",
__func__, cmd->obj.ulpevent, &asoc->ulpq);

sctp_ulpq_tail_event(&asoc->ulpq, cmd->obj.ulpevent);
asoc->stream.si->enqueue_event(&asoc->ulpq,
cmd->obj.ulpevent);
break;

case SCTP_CMD_REPLY:
Expand Down
2 changes: 1 addition & 1 deletion net/sctp/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -2294,7 +2294,7 @@ static int sctp_setsockopt_events(struct sock *sk, char __user *optval,
if (!event)
return -ENOMEM;

sctp_ulpq_tail_event(&asoc->ulpq, event);
asoc->stream.si->enqueue_event(&asoc->ulpq, event);
}
}

Expand Down
2 changes: 2 additions & 0 deletions net/sctp/stream_interleave.c
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,7 @@ static struct sctp_stream_interleave sctp_stream_interleave_0 = {
.assign_number = sctp_chunk_assign_ssn,
.validate_data = sctp_validate_data,
.ulpevent_data = sctp_ulpq_tail_data,
.enqueue_event = sctp_ulpq_tail_event,
};

static struct sctp_stream_interleave sctp_stream_interleave_1 = {
Expand All @@ -561,6 +562,7 @@ static struct sctp_stream_interleave sctp_stream_interleave_1 = {
.assign_number = sctp_chunk_assign_mid,
.validate_data = sctp_validate_idata,
.ulpevent_data = sctp_ulpevent_idata,
.enqueue_event = sctp_enqueue_event,
};

void sctp_stream_interleave_init(struct sctp_stream *stream)
Expand Down

0 comments on commit 9162e0e

Please sign in to comment.