Skip to content

Commit

Permalink
qede: Fix ref-cnt usage count
Browse files Browse the repository at this point in the history
Rebooting while qedr is loaded with a VLAN interface present
results in unregister_netdevice waiting for the usage count
to become free.
The fix is that rdma devices should be removed before unregistering
the netdevice, to assure all references to ndev are decreased.

Fixes: cee9fbd ("qede: Add qedr framework")
Signed-off-by: Ariel Elior <ariel.elior@cavium.com>
Signed-off-by: Michal Kalderon <michal.kalderon@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michal Kalderon authored and David S. Miller committed May 14, 2018
1 parent 55c8261 commit 91dfd02
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/qlogic/qede/qede_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1066,13 +1066,12 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode)

DP_INFO(edev, "Starting qede_remove\n");

qede_rdma_dev_remove(edev);
unregister_netdev(ndev);
cancel_delayed_work_sync(&edev->sp_task);

qede_ptp_disable(edev);

qede_rdma_dev_remove(edev);

edev->ops->common->set_power_state(cdev, PCI_D0);

pci_set_drvdata(pdev, NULL);
Expand Down

0 comments on commit 91dfd02

Please sign in to comment.