Skip to content

Commit

Permalink
hwmon: (nct7802) Fix integer overflow seen when writing voltage limits
Browse files Browse the repository at this point in the history
Writing a large value into a voltage limit attribute can result
in an overflow due to an auto-conversion from unsigned long to
unsigned int.

Cc: Constantine Shulyupin <const@MakeLinux.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org # v4.1+
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Guenter Roeck committed Jul 30, 2015
1 parent 0d6aaff commit 9200bc4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hwmon/nct7802.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ static int nct7802_read_voltage(struct nct7802_data *data, int nr, int index)
}

static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index,
unsigned int voltage)
unsigned long voltage)
{
int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr];
int err;
Expand Down

0 comments on commit 9200bc4

Please sign in to comment.