Skip to content

Commit

Permalink
driver-core: make sysdev_class_register check kobject_set_name return…
Browse files Browse the repository at this point in the history
… value

sysdev_class_register should check the kobject_set_name return value.

Add the return value checking code.

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dave Young authored and Greg Kroah-Hartman committed Jun 16, 2009
1 parent d9cd8f3 commit 9227c47
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/base/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,20 @@ static struct kset *system_kset;

int sysdev_class_register(struct sysdev_class *cls)
{
int retval;

pr_debug("Registering sysdev class '%s'\n", cls->name);

INIT_LIST_HEAD(&cls->drivers);
memset(&cls->kset.kobj, 0x00, sizeof(struct kobject));
cls->kset.kobj.parent = &system_kset->kobj;
cls->kset.kobj.ktype = &ktype_sysdev_class;
cls->kset.kobj.kset = system_kset;
kobject_set_name(&cls->kset.kobj, cls->name);

retval = kobject_set_name(&cls->kset.kobj, cls->name);
if (retval)
return retval;

return kset_register(&cls->kset);
}

Expand Down

0 comments on commit 9227c47

Please sign in to comment.