Skip to content

Commit

Permalink
net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy
Browse files Browse the repository at this point in the history
TCA_EXT_WARN_MSG is currently sitting outside of the expected hierarchy
for the tc actions code. It should sit within TCA_ACT_TAB.

Fixes: 0349b87 ("sched: add new attr TCA_EXT_WARN_MSG to report tc extact message")
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pedro Tammela authored and David S. Miller committed Feb 27, 2023
1 parent 724337b commit 923b2e3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/sched/act_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -1596,12 +1596,12 @@ static int tca_get_fill(struct sk_buff *skb, struct tc_action *actions[],
if (tcf_action_dump(skb, actions, bind, ref, false) < 0)
goto out_nlmsg_trim;

nla_nest_end(skb, nest);

if (extack && extack->_msg &&
nla_put_string(skb, TCA_EXT_WARN_MSG, extack->_msg))
goto out_nlmsg_trim;

nla_nest_end(skb, nest);

nlh->nlmsg_len = skb_tail_pointer(skb) - b;

return skb->len;
Expand Down

0 comments on commit 923b2e3

Please sign in to comment.