Skip to content

Commit

Permalink
bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
Browse files Browse the repository at this point in the history
Smatch warns that:

    drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
    error: uninitialized symbol 'rc'.

"rc" is either uninitialized or set to zero here so we can just remove
the check.

Fixes: 8c95f77 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Dec 6, 2017
1 parent b9f2420 commit 92425c4
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
}
}

if (rc)
return rc;

if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) {
if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) {
/* dst_fid is PF's fid */
Expand All @@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
}
}

return rc;
return 0;
}

#define GET_KEY(flow_cmd, key_type) \
Expand Down

0 comments on commit 92425c4

Please sign in to comment.