Skip to content

Commit

Permalink
crypto: qat - config VFs based on ring-to-svc mapping
Browse files Browse the repository at this point in the history
Change the configuration logic for the VF driver to leverage the
ring-to-service mappings now received via PFVF.

While the driver config logic is not yet capable of supporting
configurations other than the default mapping, make sure that both VF
and PF share the same default configuration in order to work properly.

Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Marco Chiappero authored and Herbert Xu committed Dec 24, 2021
1 parent e1b176a commit 925b306
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 13 deletions.
4 changes: 0 additions & 4 deletions drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Completion for VF2PF request/response message exchange */
init_completion(&accel_dev->vf.msg_received);

ret = qat_crypto_dev_config(accel_dev);
if (ret)
goto out_err_free_reg;

ret = adf_dev_init(accel_dev);
if (ret)
goto out_err_dev_shutdown;
Expand Down
4 changes: 0 additions & 4 deletions drivers/crypto/qat/qat_c62xvf/adf_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Completion for VF2PF request/response message exchange */
init_completion(&accel_dev->vf.msg_received);

ret = qat_crypto_dev_config(accel_dev);
if (ret)
goto out_err_free_reg;

ret = adf_dev_init(accel_dev);
if (ret)
goto out_err_dev_shutdown;
Expand Down
1 change: 1 addition & 0 deletions drivers/crypto/qat/qat_common/adf_common_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ void adf_cleanup_etr_data(struct adf_accel_dev *accel_dev);
int qat_crypto_register(void);
int qat_crypto_unregister(void);
int qat_crypto_dev_config(struct adf_accel_dev *accel_dev);
int qat_crypto_vf_dev_config(struct adf_accel_dev *accel_dev);
struct qat_crypto_instance *qat_crypto_get_instance_node(int node);
void qat_crypto_put_instance(struct qat_crypto_instance *inst);
void qat_alg_callback(void *resp);
Expand Down
9 changes: 8 additions & 1 deletion drivers/crypto/qat/qat_common/adf_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ int adf_dev_init(struct adf_accel_dev *accel_dev)
return -EFAULT;
}

if (!test_bit(ADF_STATUS_CONFIGURED, &accel_dev->status)) {
if (!test_bit(ADF_STATUS_CONFIGURED, &accel_dev->status) &&
!accel_dev->is_vf) {
dev_err(&GET_DEV(accel_dev), "Device not configured\n");
return -EFAULT;
}
Expand Down Expand Up @@ -121,6 +122,12 @@ int adf_dev_init(struct adf_accel_dev *accel_dev)
if (ret)
return ret;

if (!test_bit(ADF_STATUS_CONFIGURED, &accel_dev->status) &&
accel_dev->is_vf) {
if (qat_crypto_vf_dev_config(accel_dev))
return -EFAULT;
}

/*
* Subservice initialisation is divided into two stages: init and start.
* This is to facilitate any ordering dependencies between services
Expand Down
25 changes: 25 additions & 0 deletions drivers/crypto/qat/qat_common/qat_crypto.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "adf_transport_access_macros.h"
#include "adf_cfg.h"
#include "adf_cfg_strings.h"
#include "adf_gen2_hw_data.h"
#include "qat_crypto.h"
#include "icp_qat_fw.h"

Expand Down Expand Up @@ -104,6 +105,30 @@ struct qat_crypto_instance *qat_crypto_get_instance_node(int node)
return inst;
}

/**
* qat_crypto_vf_dev_config()
* create dev config required to create crypto inst.
*
* @accel_dev: Pointer to acceleration device.
*
* Function creates device configuration required to create
* asym, sym or, crypto instances
*
* Return: 0 on success, error code otherwise.
*/
int qat_crypto_vf_dev_config(struct adf_accel_dev *accel_dev)
{
u16 ring_to_svc_map = GET_HW_DATA(accel_dev)->ring_to_svc_map;

if (ring_to_svc_map != ADF_GEN2_DEFAULT_RING_TO_SRV_MAP) {
dev_err(&GET_DEV(accel_dev),
"Unsupported ring/service mapping present on PF");
return -EFAULT;
}

return qat_crypto_dev_config(accel_dev);
}

/**
* qat_crypto_dev_config() - create dev config required to create crypto inst.
*
Expand Down
4 changes: 0 additions & 4 deletions drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Completion for VF2PF request/response message exchange */
init_completion(&accel_dev->vf.msg_received);

ret = qat_crypto_dev_config(accel_dev);
if (ret)
goto out_err_free_reg;

ret = adf_dev_init(accel_dev);
if (ret)
goto out_err_dev_shutdown;
Expand Down

0 comments on commit 925b306

Please sign in to comment.