-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
crypto: qat - move dbgfs init to separate file
Move initialization of debugfs entries to a separate file. This simplifies the exclusion of the debugfs logic in the QAT driver when the kernel is built with CONFIG_DEBUG_FS=n. In addition, it will allow to consolidate the addition of debugfs entries to a single location in the code. This implementation adds infrastructure to create (and remove) debugfs entries at two different stages. The first, done when a device is probed, allows to keep debugfs entries persistent between a transition in device state (up to down or vice versa). The second, done after the initialization phase, allows to have debugfs entries that are accessible only when the device is up. In addition, move the creation of debugfs entries for configuration to the newly created function adf_dbgfs_init() and replace symbolic permissions with octal permissions when creating the debugfs files. This is to resolve the following warning reported by checkpatch: WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. Signed-off-by: Damian Muszynski <damian.muszynski@intel.com> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
- Loading branch information
Damian Muszynski
authored and
Herbert Xu
committed
Jun 2, 2023
1 parent
755b4e7
commit 9260db6
Showing
13 changed files
with
156 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // SPDX-License-Identifier: GPL-2.0-only | ||
| /* Copyright(c) 2023 Intel Corporation */ | ||
|
|
||
| #include <linux/debugfs.h> | ||
| #include "adf_accel_devices.h" | ||
| #include "adf_cfg.h" | ||
| #include "adf_common_drv.h" | ||
| #include "adf_dbgfs.h" | ||
|
|
||
| /** | ||
| * adf_dbgfs_init() - add persistent debugfs entries | ||
| * @accel_dev: Pointer to acceleration device. | ||
| * | ||
| * This function creates debugfs entries that are persistent through a device | ||
| * state change (from up to down or vice versa). | ||
| */ | ||
| void adf_dbgfs_init(struct adf_accel_dev *accel_dev) | ||
| { | ||
| char name[ADF_DEVICE_NAME_LENGTH]; | ||
| void *ret; | ||
|
|
||
| /* Create dev top level debugfs entry */ | ||
| snprintf(name, sizeof(name), "%s%s_%s", ADF_DEVICE_NAME_PREFIX, | ||
| accel_dev->hw_device->dev_class->name, | ||
| pci_name(accel_dev->accel_pci_dev.pci_dev)); | ||
|
|
||
| ret = debugfs_create_dir(name, NULL); | ||
| if (IS_ERR_OR_NULL(ret)) | ||
| return; | ||
|
|
||
| accel_dev->debugfs_dir = ret; | ||
|
|
||
| adf_cfg_dev_dbgfs_add(accel_dev); | ||
| } | ||
| EXPORT_SYMBOL_GPL(adf_dbgfs_init); | ||
|
|
||
| /** | ||
| * adf_dbgfs_exit() - remove persistent debugfs entries | ||
| * @accel_dev: Pointer to acceleration device. | ||
| */ | ||
| void adf_dbgfs_exit(struct adf_accel_dev *accel_dev) | ||
| { | ||
| adf_cfg_dev_dbgfs_rm(accel_dev); | ||
| debugfs_remove(accel_dev->debugfs_dir); | ||
| } | ||
| EXPORT_SYMBOL_GPL(adf_dbgfs_exit); | ||
|
|
||
| /** | ||
| * adf_dbgfs_add() - add non-persistent debugfs entries | ||
| * @accel_dev: Pointer to acceleration device. | ||
| * | ||
| * This function creates debugfs entries that are not persistent through | ||
| * a device state change (from up to down or vice versa). | ||
| */ | ||
| void adf_dbgfs_add(struct adf_accel_dev *accel_dev) | ||
| { | ||
| if (!accel_dev->debugfs_dir) | ||
| return; | ||
| } | ||
|
|
||
| /** | ||
| * adf_dbgfs_rm() - remove non-persistent debugfs entries | ||
| * @accel_dev: Pointer to acceleration device. | ||
| */ | ||
| void adf_dbgfs_rm(struct adf_accel_dev *accel_dev) | ||
| { | ||
| if (!accel_dev->debugfs_dir) | ||
| return; | ||
| } |
Oops, something went wrong.