Skip to content

Commit

Permalink
mtd: nand: Change dependency between the NAND and ECC cores
Browse files Browse the repository at this point in the history
The NAND ECC core is included in the generic NAND core when it is
compiled in.

Different software ECC engines drivers will select the NAND ECC core
and thus also have a dependency on the NAND core. Using a "depends on"
between the two leads to possible cases (not real cases, but created
by robots) where one is still unselected because of the "select does
not verifies depends on" game:

WARNING: unmet direct dependencies detected for MTD_NAND_ECC
  Depends on [n]: MTD [=m] && MTD_NAND_CORE [=n]
  Selected by [m]:
  - MTD_NAND_ECC_SW_HAMMING [=y] && MTD [=m]
  - MTD_NAND_ECC_SW_BCH [=y] && MTD [=m]

Fix this by using a select instead.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Link: https://lore.kernel.org/linux-mtd/20201113123945.32592-1-miquel.raynal@bootlin.com
  • Loading branch information
Miquel Raynal committed Dec 10, 2020
1 parent 131ce3e commit 928f073
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mtd/nand/Kconfig
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ menu "ECC engine support"

config MTD_NAND_ECC
bool
depends on MTD_NAND_CORE
select MTD_NAND_CORE

config MTD_NAND_ECC_SW_HAMMING
bool "Software Hamming ECC engine"

0 comments on commit 928f073

Please sign in to comment.