Skip to content

Commit

Permalink
Input: uinput - take event lock when fetching events from buffer
Browse files Browse the repository at this point in the history
When fetching events form device's buffer in uinput_read() we need to
take input device's event_lock to avoid racing with new event delivery.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Dmitry Torokhov committed Aug 22, 2012
1 parent c0bb1f9 commit 929d1af
Showing 1 changed file with 24 additions and 3 deletions.
27 changes: 24 additions & 3 deletions drivers/input/misc/uinput.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,28 @@ static ssize_t uinput_write(struct file *file, const char __user *buffer, size_t
return retval;
}

static bool uinput_fetch_next_event(struct uinput_device *udev,
struct input_event *event)
{
bool have_event;

spin_lock_irq(&udev->dev->event_lock);

have_event = udev->head != udev->tail;
if (have_event) {
*event = udev->buff[udev->tail];
udev->tail = (udev->tail + 1) % UINPUT_BUFFER_SIZE;
}

spin_unlock_irq(&udev->dev->event_lock);

return have_event;
}

static ssize_t uinput_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos)
{
struct uinput_device *udev = file->private_data;
struct input_event event;
int retval = 0;

if (udev->state != UIST_CREATED)
Expand All @@ -477,12 +496,14 @@ static ssize_t uinput_read(struct file *file, char __user *buffer, size_t count,
goto out;
}

while (udev->head != udev->tail && retval + input_event_size() <= count) {
if (input_event_to_user(buffer + retval, &udev->buff[udev->tail])) {
while (retval + input_event_size() <= count &&
uinput_fetch_next_event(udev, &event)) {

if (input_event_to_user(buffer + retval, &event)) {
retval = -EFAULT;
goto out;
}
udev->tail = (udev->tail + 1) % UINPUT_BUFFER_SIZE;

retval += input_event_size();
}

Expand Down

0 comments on commit 929d1af

Please sign in to comment.