Skip to content

Commit

Permalink
r8169: improve phy initialization when resuming
Browse files Browse the repository at this point in the history
Let's move calling rtl8169_init_phy() to __rtl8169_resume().
It simplifies the code and avoids rtl8169_init_phy() being called
when resuming whilst interface is down. rtl_open() will initialize
the PHY when the interface is brought up.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Jun 25, 2018
1 parent 064f390 commit 92bad85
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/net/ethernet/realtek/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -7334,6 +7334,7 @@ static void __rtl8169_resume(struct net_device *dev)
netif_device_attach(dev);

rtl_pll_power_up(tp);
rtl8169_init_phy(dev, tp);

rtl_lock_work(tp);
napi_enable(&tp->napi);
Expand All @@ -7347,9 +7348,6 @@ static int rtl8169_resume(struct device *device)
{
struct pci_dev *pdev = to_pci_dev(device);
struct net_device *dev = pci_get_drvdata(pdev);
struct rtl8169_private *tp = netdev_priv(dev);

rtl8169_init_phy(dev, tp);

if (netif_running(dev))
__rtl8169_resume(dev);
Expand Down Expand Up @@ -7397,8 +7395,6 @@ static int rtl8169_runtime_resume(struct device *device)
tp->saved_wolopts = 0;
rtl_unlock_work(tp);

rtl8169_init_phy(dev, tp);

__rtl8169_resume(dev);

return 0;
Expand Down

0 comments on commit 92bad85

Please sign in to comment.