Skip to content

Commit

Permalink
fbdev: nvidia: Fix potential divide by zero
Browse files Browse the repository at this point in the history
variable var->pixclock can be set by user. In case it
equals to zero, divide by zero would occur in nvidiafb_set_par.

Similar crashes have happened in other fbdev drivers. There
is no check and modification on var->pixclock along the call
chain to nvidia_check_var and nvidiafb_set_par. We believe it
could also be triggered in driver nvidia from user site.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Wei Chen authored and Helge Deller committed Mar 16, 2023
1 parent 203873a commit 92e2a00
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/video/fbdev/nvidia/nvidia.c
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,8 @@ static int nvidiafb_check_var(struct fb_var_screeninfo *var,
int pitch, err = 0;

NVTRACE_ENTER();
if (!var->pixclock)
return -EINVAL;

var->transp.offset = 0;
var->transp.length = 0;
Expand Down

0 comments on commit 92e2a00

Please sign in to comment.