Skip to content

Commit

Permalink
net_sched: move from strlcpy with unused retval to strscpy
Browse files Browse the repository at this point in the history
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220818210228.8635-1-wsa+renesas@sang-engineering.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Wolfram Sang authored and Jakub Kicinski committed Aug 23, 2022
1 parent 19d1c04 commit 92f24c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion net/sched/sch_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ EXPORT_SYMBOL(unregister_qdisc);
void qdisc_get_default(char *name, size_t len)
{
read_lock(&qdisc_mod_lock);
strlcpy(name, default_qdisc_ops->id, len);
strscpy(name, default_qdisc_ops->id, len);
read_unlock(&qdisc_mod_lock);
}

Expand Down
2 changes: 1 addition & 1 deletion net/sched/sch_teql.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ static int __init teql_init(void)

master = netdev_priv(dev);

strlcpy(master->qops.id, dev->name, IFNAMSIZ);
strscpy(master->qops.id, dev->name, IFNAMSIZ);
err = register_qdisc(&master->qops);

if (err) {
Expand Down

0 comments on commit 92f24c6

Please sign in to comment.