Skip to content

Commit

Permalink
pinctrl: cherryview: Drop goto label
Browse files Browse the repository at this point in the history
We do not use goto labels in the Intel pin control drivers,
so drop the only one in the entire folder.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  • Loading branch information
Andy Shevchenko committed Jun 19, 2023
1 parent 605ba25 commit 9314d05
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/pinctrl/intel/pinctrl-cherryview.c
Original file line number Diff line number Diff line change
Expand Up @@ -1413,8 +1413,10 @@ static int chv_gpio_irq_type(struct irq_data *d, unsigned int type)
raw_spin_lock_irqsave(&chv_lock, flags);

ret = chv_gpio_set_intr_line(pctrl, hwirq);
if (ret)
goto out_unlock;
if (ret) {
raw_spin_unlock_irqrestore(&chv_lock, flags);
return ret;
}

/*
* Pins which can be used as shared interrupt are configured in
Expand Down Expand Up @@ -1455,10 +1457,9 @@ static int chv_gpio_irq_type(struct irq_data *d, unsigned int type)
else if (type & IRQ_TYPE_LEVEL_MASK)
irq_set_handler_locked(d, handle_level_irq);

out_unlock:
raw_spin_unlock_irqrestore(&chv_lock, flags);

return ret;
return 0;
}

static const struct irq_chip chv_gpio_irq_chip = {
Expand Down

0 comments on commit 9314d05

Please sign in to comment.